Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📙 Adding at least logging, and some wrong code to HangUpMedia #35

Merged
merged 2 commits into from
Dec 26, 2020
Merged

📙 Adding at least logging, and some wrong code to HangUpMedia #35

merged 2 commits into from
Dec 26, 2020

Conversation

clone1018
Copy link
Member

No description provided.

@clone1018 clone1018 requested a review from haydenmc November 18, 2020 02:30
@clone1018
Copy link
Member Author

Fixes??? #33 ???

haydenmc
haydenmc reviewed Nov 18, 2020
View reviewed changes
Copy link
Member

@haydenmc haydenmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gets us at least part of the way there! I think we will need to make sure this session gets pulled out of viewer lists for FTL streams as well - see FtlStreamStore

@haydenmc
Copy link
Member

Touching this up a bit to only log for now so we can help confirm #47 and #33

@haydenmc haydenmc merged commit 4b8be37 into master Dec 26, 2020
@haydenmc haydenmc deleted the clone1018-patch-1 branch December 26, 2020 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haydenmc haydenmc haydenmc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clone1018 @haydenmc