📦 Hand RTP packets directly to JanusStream #106
Conversation
danstiner
force-pushed
the
danstiner/rtp-packet-sink
branch
from
7143ed9 to
caed328
Compare
|
Tested locally on edge and ingest nodes. I see about 0.6% dropped frames and I'm not sure why. Will test if I see the same an older commit but I suspect I will. (webrtc-internals says 0 nacks, but 30+ picture loss indicators so it might even be an issue on the decoding side) |
Possible you're running into #101? If you're only seeing freezes and not actual packet loss. |
src/JanusStream.cpp
Outdated
|
|
||
| void JanusStream::StopRelays() | ||
| { | ||
| std::lock_guard lock(mutex); |
There was a problem hiding this comment.
This is my only remaining concern, and you said something over voip about this being reasonable, so it could be that my concern is not warranted. :)
There was a problem hiding this comment.
(concern being holding a lock while stopping every individual relay)
There was a problem hiding this comment.
I think my justification was if this is only called when we're killing the stream, so we don't care about delaying packets. But might as well clean it up.
There was a problem hiding this comment.
Cleaned it up with some swaps
Resolves infinite loop introduced by #106
Going back and doing ebefe00 the right way this time.
This shortens the path for RTP packets to only require a single lock at the stream level.