Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement JanusFtl::HangUpMedia #33

Open
haydenmc opened this issue Oct 19, 2020 · 1 comment
Open

Implement JanusFtl::HangUpMedia #33

haydenmc opened this issue Oct 19, 2020 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@haydenmc
Copy link
Member

haydenmc commented Oct 19, 2020 •
edited
Loading

This is probably causing a significant amount of our srtp errors. We should be resetting the rtp context and shutting everything down when we see a hang-up signal.

In the short term it's probably worth adding some logging here so we can at least try to confirm the correlation between this TODO and the srtp errors.
@haydenmc haydenmc changed the title Implement hang-up Implement JanusFtl::HangUpMedia Oct 19, 2020
@clone1018 clone1018 mentioned this issue Nov 18, 2020
Merged
@haydenmc haydenmc added the enhancement New feature or request label Nov 30, 2020
@haydenmc haydenmc added bug Something isn't working ship blocker Need this resolved to ship labels Dec 9, 2020
@haydenmc haydenmc mentioned this issue Dec 14, 2020
Open
haydenmc added a commit that referenced this issue Dec 26, 2020
@clone1018 @haydenmc
📙 Add logging to HangUpMedia (#35)
4b8be37 
We log whenever a session calls HangUpMedia, which we haven't implemented yet.

This should help us nail down the source of #47 and #33

Co-authored-by: Hayden McAfee <[email protected]>
@haydenmc
Copy link
Member Author

Per our recent meeting, removing the ship blocking tag - asking viewers to refresh if their stream isn't coming through is an acceptable alpha experience.

@haydenmc haydenmc removed the ship blocker Need this resolved to ship label Feb 16, 2021
@haydenmc haydenmc mentioned this issue Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@haydenmc