Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin Rasterio<1.4 now that 2D xy/rowcol fixed #615

Merged
merged 5 commits into from
Nov 8, 2024
Merged

Unpin Rasterio<1.4 now that 2D xy/rowcol fixed #615

merged 5 commits into from
Nov 8, 2024

Conversation

rhugonnet
Copy link
Member

Resolves #597

@rhugonnet rhugonnet changed the title Unpin Rasterio<1.4 with new fixes Unpin Rasterio<1.4 with upstream fixes Oct 24, 2024
@rhugonnet rhugonnet changed the title Unpin Rasterio<1.4 with upstream fixes Unpin Rasterio<1.4 now that 2D xy/rowcol fixed Oct 24, 2024
@rhugonnet
Copy link
Member Author

Ran this again with Rasterio 1.4.1, still failing. Need to look into it in more details...

@rhugonnet rhugonnet merged commit 5d4cd2f into GlacioHack:main Nov 8, 2024
19 checks passed
@rhugonnet rhugonnet deleted the unpin_rio branch November 8, 2024 23:58
@rhugonnet
Copy link
Member Author

FYI: The error that was raised in Rasterio 1.4.0 was fixed in 1.4.1.
However, the functions xy and rowcol do not support any other input than 1D anymore (previously ND), and this is intended behaviour.
So this PR reshapes the input/output to solve this (and still be backwards-compatible with Rasterio pre1.4).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unpin Rasterio 1.3 once 2D xy/rowcol fixed in 1.4.1
1 participant
@rhugonnet