Add ICP in Python #581
Draft
Add ICP in Python #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting!! Is opencv an essential requirement for xdem if this method ends up being on-par with or outperforming the current ICP? |
I checked myself and realized I'd forgotten that opencv is already (technically) an optional dependency! I looked through where opencv is used and it's kind of not really, apart from in co-registration. So an argument (and separate issue/PR) could be made to remove it altogether! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #530, we can add a Python-based ICP relying on the same core functions as other coregs.
This will allow us to control the method in more details (weights, type of ICP), and to remove the optional OpenCV dependency that is a heavy one.
Resolves #483
Ongoing