New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in `CoregPipeline.fit()` #449

Closed

rhugonnet wants to merge 0 commits into GlacioHack:main from rhugonnet:fix_pipeline

Member

rhugonnet commented Nov 28, 2023 •

edited

Loading

This PR fixes a bug in CoregPipeline that made all fits erroneous (using the original tba_dem instead of the updated one).

This was only 4 characters, but not easy to find.

I also removed the old CoregPipeline._fit_func() now superseeded by CoregPipeline.fit().

Resolves Coregistration: Tilt and VerticalShift pipelines in 0.0.16 #447,
Tests added, otherwise issue #xxx opened.

rhugonnet closed this

rhugonnet force-pushed the fix_pipeline branch from 0fbe0ad to a72b910 Compare

November 28, 2023 02:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet