-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sampling in NuthKaab
and set better default values for other classes
#439
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good!
The changes in the tests are related to the fact that the automatically generated ddem has changed because of the change in the coregistration subsamplimg?
Some other tests seem to fail though... |
Thanks! Yes it's the new subsampling that yields different values. For the test not passing: it looks like the randomness of results is not fixed between different OS again... Joins #310. Will investigate... |
Haha, I like the many different attempts to make it work !! 🤣 |
This PR fixes:
NuthKaab
that was done a bit too early, where NaNs introduced by slope/aspect could become problematic (somehow the tests were less sensitive to this).Deramp
that didn't have a defaultsubsample
value set for more reasonable computing times, now all changed to5e5
.Tilt
.Additionally, the previous way of installing the base environment for CI (concatenating YML dependencies without the Python version from a script
get_yml_env_nopy
) was failing on Windows when dependencies were pinned with a<
, for example when I triedscipy<1.11.1
to ensure the randomness problem didn't come from there.Now the script is renamed
generate_yml_env_fixed_py
, and generates a temporary YML file during CI to feed toconda
, which parses all types of pinning without issues on Windows!I'm leaving
scipy<1.11.1
, which also makes variogram modelling fail, will reactivate once they release1.11.4
: #430