Skip to content

Commit

Permalink
Finalize eriks comments
Browse files Browse the repository at this point in the history
  • Loading branch information
rhugonnet committed Sep 25, 2023
1 parent 0abc6e8 commit 4839c09
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
4 changes: 2 additions & 2 deletions dev-environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ dependencies:
- tqdm
- scikit-image
- scikit-gstat>=1.0
# - geoutils=0.0.14
- geoutils=0.0.15

# Development-specific, to mirror manually in setup.cfg [options.extras_require].
- pip
Expand Down Expand Up @@ -52,4 +52,4 @@ dependencies:
- noisyopt

# To run CI against latest GeoUtils
- git+https://github.com/GlacioHack/geoutils.git
# - git+https://github.com/GlacioHack/geoutils.git
4 changes: 2 additions & 2 deletions environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ dependencies:
- tqdm
- scikit-image
- scikit-gstat>=1.0
# - geoutils=0.0.14
- geoutils=0.0.15
- pip

- pip:
- git+https://github.com/GlacioHack/geoutils.git
# - git+https://github.com/GlacioHack/geoutils.git
2 changes: 1 addition & 1 deletion tests/test_coreg/test_affine.py
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ def test_tilt(self) -> None:
assert np.abs(np.mean(periglacial_offset)) < np.abs(np.mean(pre_offset))

# Check that the mean periglacial offset is low
assert np.abs(np.mean(periglacial_offset)) < 2
assert np.abs(np.mean(periglacial_offset)) < 0.01

def test_icp_opencv(self) -> None:
warnings.simplefilter("error")
Expand Down
1 change: 1 addition & 0 deletions xdem/coreg/affine.py
Original file line number Diff line number Diff line change
Expand Up @@ -621,6 +621,7 @@ def _fit_func(
) -> None:
"""Fit the dDEM between the DEMs to a least squares polynomial equation."""
ddem = ref_dem - tba_dem
ddem[~inlier_mask] = np.nan
x_coords, y_coords = _get_x_and_y_coords(ref_dem.shape, transform)
fit_ramp, coefs = deramping(
ddem, x_coords, y_coords, degree=self.poly_order, subsample=self._meta["subsample"], verbose=verbose
Expand Down

0 comments on commit 4839c09

Please sign in to comment.