Add Raster.from_xarray() to create raster from a xr.DataArray
#521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhugonnet
commented
Mar 17, 2024
| @@ -1523,6 +1529,7 @@ def set_nodata( | |||
|
|
|||
| # Update the nodata value | |||
| self._nodata = new_nodata | |||
| self.data.fill_value = new_nodata | |||
There was a problem hiding this comment.
This little addition was necessary to make raster_equal (which checks fill_values are equal between raster's masked arrays) happy when set_nodata is called!
rhugonnet
changed the title
Raster.from_xarray() to convert from a Xarray.DataArrayRaster.from_xarray() to create raster from a xr.DataArray
…dd convenience arguments to raster_equal()
adehecq
reviewed
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Raster.from_xarray()to create a raster from an Xarray dataset (this loads the data, in the future will be able to cast functions directly on the Xarray object through #446).Correct the behaviour of
to_xarray()which was not converting the data to floating when converting, and not masking nodata values (as default wasFalsefor reading mask inopen_rasterio()), leading to unmasked nodata values for integer raster types. Now converts to floating by defaults to mask properly as NaNs (only way of masking with Xarray).Additionally, this function adds two new arguments to
Raster.raster_equal():strict_maskedandwarn_failure_reason. The former allows to check for less strict equality regarding the mask (masked cells can have different underlying values, as those are never used anyway), and the latter is to raise an understandable error whenraster_equal()assertions fail.We lose information when converting to an Xarray dataset with NaNs (masked values are transformed to NaNs and cannot be retrieved back when re-creating a raster), so we can only check equality with
strict_masked=False.Resolves #519
Resolves #522