This repository has been archived by the owner on Aug 18, 2024. It is now read-only.
Default argument for current user memberships. #253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerolab
reviewed
Apr 13, 2017
zerolab
reviewed
Apr 13, 2017
This comment has been minimized.
This comment has been minimized.
tombola
force-pushed
the
default-argument-membership
branch
from
f6d5007
to
1e6f95f
Compare
This comment has been minimized.
This comment has been minimized.
amitaibu
reviewed
Apr 19, 2017
| */ | ||
| public function getArgument() { | ||
| // Currently restricted to node entities. | ||
| return implode(',', $this->getCurrentUserGroupIds('node')); |
There was a problem hiding this comment.
I think we could make it configurable - and expose the group related entities
There was a problem hiding this comment.
That does sound a worthwhile aim.
I would likely need to return to this at a later date if I were to help with that though.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
zerolab
reviewed
Jun 22, 2017
MPParsley
reviewed
Jul 23, 2018
There was a problem hiding this comment.
Added some small comments wrt the phpdocs.
Since a user with the permission "administer group" has access to all of the groups, wouldn't it be useful to add an option to list all groups for users with this permission?
With exception for @amitaibu's remark on making the entity type configurable this seems to be ready.
MPParsley
reviewed
Sep 26, 2018
MPParsley
reviewed
May 28, 2019
MPParsley
reviewed
May 28, 2019
MPParsley
reviewed
May 28, 2019
MPParsley
reviewed
May 28, 2019
MPParsley
reviewed
May 28, 2019
MPParsley
reviewed
May 28, 2019
MPParsley
reviewed
May 28, 2019
|
@tombola, could you add me as an author so I can fix the remarks/tests? |
MPParsley
reviewed
Aug 21, 2019
This was referenced Aug 21, 2019
|
Closing in favor of #565. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #254:
Default argument to populate the contextual filter (eg groups_audience) used by the view.