Skip to content
This repository has been archived by the owner on Aug 18, 2024. It is now read-only.

[WIP] OG Access port #242

Closed
wants to merge 44 commits into from
Closed

[WIP] OG Access port #242

wants to merge 44 commits into from

Conversation

zerolab
Copy link
Contributor

@zerolab zerolab commented Mar 6, 2017

This is the start for the OG Access module port.

Took a simple approach to group content visibility. It mirrors that of the group visibility (public, private). If any of the groups the content is assigned is private, then we mark it as private.

Any feedback at this stage would be most welcome.

Tasks:

  • Grants and node access
  • Create batch to process changes to group visibility
  • Tests

amitaibu
amitaibu reviewed Mar 6, 2017
View reviewed changes
Copy link
Member

@amitaibu amitaibu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see you giving Og Access some love :)

I've added a couple of comments

og_access/og_access.install Outdated Show resolved Hide resolved
og_access/og_access.module Outdated Show resolved Hide resolved
og_access/og_access.module Outdated Show resolved Hide resolved
@zerolab zerolab mentioned this pull request Mar 27, 2017
Open
@zerolab zerolab mentioned this pull request Jun 17, 2017
Open
@zerolab zerolab mentioned this pull request Jul 27, 2017
Open
@joachim-n
Copy link

I just got stung by there being two classes called BundleFormAlter once this is merged in.

Is there a good alternative name for the one in OG access?

@joachim-n joachim-n mentioned this pull request Sep 21, 2017
Merged
@pfrenssen

This comment has been minimized.

Sign in to view
@zerolab

This comment has been minimized.

Sign in to view
@tatarbj

This comment has been minimized.

Sign in to view
@zerolab

This comment has been minimized.

Sign in to view
@tatarbj

This comment has been minimized.

Sign in to view
@tatarbj @zerolab
Gizra#242 Improvements for og_access port. (#2)
202c31c 
* Gizra#242 Remove og_ui dependency, replace defines with OgAccess class and its consts, also in the whole module.

* Gizra#242 Grammar issue is fixed.

* Gizra#242 Introduce service injection and replace t() with the injected one.

* Gizra#242 PHPCS fixes.
@MPParsley MPParsley linked an issue Aug 15, 2020 that may be closed by this pull request
'Organic groups access control module' in settings form should be a link #293
Open
gheydon pushed a commit to gheydon/og that referenced this pull request Oct 26, 2020
@tatarbj @gheydon
Gizra#242 Improvements for og_access port. (Gizra#2)
479f8ed 
* Gizra#242 Remove og_ui dependency, replace defines with OgAccess class and its consts, also in the whole module.

* Gizra#242 Grammar issue is fixed.

* Gizra#242 Introduce service injection and replace t() with the injected one.

* Gizra#242 PHPCS fixes.
@MPParsley MPParsley mentioned this pull request Apr 21, 2021
Closed
@MPParsley MPParsley modified the milestones: 8.x-1.0, 8.x-1.0-beta1 Sep 15, 2021
@cofihouse cofihouse mentioned this pull request Jul 31, 2022
Closed
@claudiu-cristea
Copy link
Collaborator

Since https://www.drupal.org/project/og/issues/3467694 was merged into the 8.x-1.x branch, the development has been moved to https://www.drupal.org/project/og. If this change is still actual, please open an issue at https://www.drupal.org/project/issues/og and provide there a merge request similar with this pull request.

Thank you for contributing to Organic groups module.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lennartvava lennartvava lennartvava approved these changes

@edvanleeuwen edvanleeuwen edvanleeuwen left review comments

@agallewale agallewale agallewale left review comments

@MPParsley MPParsley MPParsley left review comments

@tatarbj tatarbj tatarbj left review comments

@amitaibu amitaibu amitaibu left review comments

@joachim-n joachim-n joachim-n left review comments

Assignees
No one assigned
Labels
Beta blocker Drupal 8 Needs tests
Projects
None yet
Milestone
8.x-1.0-beta1
Development

Successfully merging this pull request may close these issues.

'Organic groups access control module' in settings form should be a link Private group functionality (D8)