Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ System timezone on UNIX systems #3

Merged
merged 3 commits into from
Oct 8, 2023
Merged

✨ System timezone on UNIX systems #3

merged 3 commits into from
Oct 8, 2023

Conversation

GiyoMoon
Copy link
Owner

@GiyoMoon GiyoMoon commented Oct 7, 2023

This pull request adds support for system timezone on UNIX systems. It parses the TZif file under /etc/localtime to get the UTC offset at any given timestamp.

https://www.rfc-editor.org/rfc/rfc8536.html

  • Basic implementation
  • Correctly parse and use the TZ string from the footer in Version 3 TZif files see here
  • Proper error handling
  • Tests

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2023

Codecov Report

Merging #3 (773ba48) into main (985b2b2) will decrease coverage by 0.01%.
The diff coverage is 99.93%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
- Coverage   99.92%   99.91%   -0.01%     
==========================================
  Files          18       25       +7     
  Lines        3860     4911    +1051     
==========================================
+ Hits         3857     4907    +1050     
- Misses          3        4       +1     
Files Coverage Δ
src/cron.rs 99.07% <100.00%> (-0.03%) ⬇️
src/date.rs 100.00% <100.00%> (ø)
src/datetime.rs 100.00% <100.00%> (ø)
src/local/cursor.rs 100.00% <100.00%> (ø)
src/local/data_block.rs 100.00% <100.00%> (ø)
src/local/errors.rs 100.00% <100.00%> (ø)
src/local/header.rs 100.00% <100.00%> (ø)
src/local/timezone.rs 100.00% <100.00%> (ø)
src/local/transition_rule.rs 100.00% <100.00%> (ø)
src/shared.rs 100.00% <ø> (ø)
... and 4 more

@GiyoMoon GiyoMoon changed the title Draft: ✨ System timezone on UNIX systems ✨ System timezone on UNIX systems Oct 8, 2023
@GiyoMoon GiyoMoon merged commit 9408b7b into main Oct 8, 2023
10 checks passed
@GiyoMoon GiyoMoon deleted the features/local branch October 8, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants