Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pack receive #1731

Merged
merged 6 commits into from
Dec 20, 2024
Merged

fix pack receive #1731

merged 6 commits into from
Dec 20, 2024

Conversation

Byron
Copy link
Member

@Byron Byron commented Dec 20, 2024

This also re-enabled git-daemon on CI, which technically was just a workaround as it basically also didn't work locally.

In any case, now it works as it won't leave the server in a strange state due to not indicating the end of interaction.

My guess is that somehow the server would see its slots filled up with hanging processes, leading it to stop accepting
connections and probably also to stop going down.

@Byron Byron marked this pull request as ready for review December 20, 2024 18:57
Otherwise we will fail to produce a nice error message.
It became clear that the issue was home-made. The remote interactions of
the 'free' variants never terminated the connection, which could have left
the daemon hanging.

It might have filled up its 32 slots, leading to rejection later, maybe.
It is possible for the negotiation to go on forever if implemented incorrectly
on the client side. Hence it's useful to gracefully interrupt it.
@Byron Byron enabled auto-merge December 20, 2024 19:20
@Byron Byron mentioned this pull request Dec 20, 2024
2 tasks
@Byron Byron merged commit ca54b8c into main Dec 20, 2024
20 checks passed
@EliahKagan
Copy link
Member

This worked out great--a bug is fixed and the tests are working again and reenabled for CI! 🎉

@Byron Byron deleted the fix-pack-receive branch December 22, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants