Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Work around nextest macro lib compatibility bug" #1376

Merged
merged 1 commit into from
May 24, 2024

Conversation

EliahKagan
Copy link
Member

@EliahKagan EliahKagan commented May 23, 2024

cargo-nextest 0.9.71 has been released, which contains the fix in nextest-rs/nextest#1499 for nextest-rs/nextest#1493.

As confirmed on nextest's own CI--and for this project in runs on my fork before and after the new cargo-nextest release--this makes it so the workaround in this repository's test-fast CI job, introduced in #1372, is no longer necessary.

Since that change made the workflow slightly more complicated and was intended as temporary, this PR reverts #1372.

@Byron Byron merged commit f9c2623 into GitoxideLabs:main May 24, 2024
19 checks passed
@Byron
Copy link
Member

Byron commented May 24, 2024

Thanks a lot for your help!

@EliahKagan EliahKagan deleted the revert-1372-find-dll branch May 24, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants