Skip to content

Commit

Permalink
Run check-mode recipe on CI via ci-test recipe
Browse files Browse the repository at this point in the history
This adds the `check-mode` recipe to the `test` recipe and, more
significantly because of its effect on CI, to the `ci-test` recipe.

This causes the CI `test` job to run the `check-mode` recipe (and
thus `it check-mode` through it).

While the separate `check-mode` CI job was useful for developing
the tool, it imposes extra work, due to the need to build
dependencies that are, to a substantial extent, shared with those
already present (and cached) for the `test` job. Now that it is
run via the `test` CI job, the separate `check-mode` CI job is
removed.
  • Loading branch information
EliahKagan committed Nov 29, 2024
1 parent 2305099 commit 8729858
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 13 deletions.
11 changes: 0 additions & 11 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -359,16 +359,6 @@ jobs:
- name: gix-pack with all features (including wasm)
run: cd gix-pack && cargo build --all-features --target "$TARGET"

check-mode:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
- uses: extractions/setup-just@v2
- name: Find scripts with mode/shebang mismatch
run: just check-mode

check-packetline:
strategy:
fail-fast: false
Expand Down Expand Up @@ -451,7 +441,6 @@ jobs:
- test-32bit-cross
- lint
- cargo-deny
- check-mode
- check-packetline
- check-blocking

Expand Down
4 changes: 2 additions & 2 deletions justfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ alias c := check
alias nt := nextest

# run all tests, clippy, including journey tests, try building docs
test: clippy check doc unit-tests journey-tests-pure journey-tests-small journey-tests-async journey-tests
test: clippy check doc unit-tests journey-tests-pure journey-tests-small journey-tests-async journey-tests check-mode

# run all tests, without clippy, and try building docs
ci-test: check doc unit-tests
ci-test: check doc unit-tests check-mode

# run all journey tests - should be run in a fresh clone or after `cargo clean`
ci-journey-tests: journey-tests-pure journey-tests-small journey-tests-async journey-tests
Expand Down

0 comments on commit 8729858

Please sign in to comment.