Skip to content

Commit

Permalink
Simplify the check-mode CI job
Browse files Browse the repository at this point in the history
By running it only on Ubuntu (not macOS and Windows), and removing
parts that were only needed for running it on Windows.

Unlike `etc/copy-packetline.sh`, the `etc/check-mode.sh` script
probably does not need to be made easy to retest on other platforms
after changes, becaus it does not delete (nor otherwise modify) the
repository, and becuase it is considerably shorter, simpler, and
less reliant on subtleties of standard tools that vary across
platforms.
  • Loading branch information
EliahKagan committed Nov 28, 2024
1 parent ed757ea commit 82cbc0a
Showing 1 changed file with 1 addition and 11 deletions.
12 changes: 1 addition & 11 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -360,17 +360,7 @@ jobs:
run: cd gix-pack && cargo build --all-features --target "$TARGET"

check-mode:
# FIXME: Only run this on ubuntu-latest (don't use a matrix).
strategy:
fail-fast: false
matrix:
os: [ ubuntu-latest, macos-latest, windows-latest ]

runs-on: ${{ matrix.os }}

defaults:
run:
shell: bash
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
Expand Down

0 comments on commit 82cbc0a

Please sign in to comment.