Skip to content

Commit

Permalink
fix: add support for 'any' unit, when parsing <count> <unit> ago.
Browse files Browse the repository at this point in the history
Similar to Git, any unit is allowed and will default to seconds, like `60 flurps ago`
will mean a minute in the past.
  • Loading branch information
Byron authored and EliahKagan committed Nov 25, 2024
1 parent 856b385 commit 34d2fce
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion gix-date/src/parse.rs
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ mod relative {
"month" => Span::new().try_months(units),
"year" => Span::new().try_years(units),
// Ignore values you don't know, assume seconds then (so does git)
_ => return None,
_anything => Span::new().try_seconds(units),
};
Some(result.map_err(|_| Error::RelativeTimeConversion))
}
Expand Down
1 change: 1 addition & 0 deletions gix-date/tests/time/parse.rs
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ mod relative {
// For comparison, a few are the same as in: https://github.com/git/git/blob/master/t/t0006-date.sh
let cases = [
("5 seconds ago", 5.seconds()),
("12345 florx ago", 12_345.seconds()), // Anything parses as seconds
("5 minutes ago", 5.minutes()),
("5 hours ago", 5.hours()),
("5 days ago", 5.days()),
Expand Down

0 comments on commit 34d2fce

Please sign in to comment.