Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/gsk 1819 set a minimum on langchains version #1507

Merged
merged 5 commits into from
Oct 25, 2023
Merged

Feature/gsk 1819 set a minimum on langchains version #1507

merged 5 commits into from
Oct 25, 2023

Conversation

Hartorn
Copy link
Member

@Hartorn Hartorn commented Oct 25, 2023

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@Hartorn Hartorn requested a review from rabah-khalek October 25, 2023 14:22
@Hartorn Hartorn self-assigned this Oct 25, 2023
@linear
Copy link

linear bot commented Oct 25, 2023

GSK-1819 Set a minimum on langchain's version

I had langchain 0.266 but it broke our use of

ChatPromptTemplate.from_messages(...)

@Hartorn Hartorn force-pushed the feature/gsk-1819-set-a-minimum-on-langchains-version branch from d47eafa to 2172995 Compare October 25, 2023 14:26
@Hartorn Hartorn marked this pull request as ready for review October 25, 2023 18:57
@Hartorn Hartorn requested a review from a team as a code owner October 25, 2023 18:57
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

rabah-khalek
rabah-khalek approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@rabah-khalek rabah-khalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rabah-khalek rabah-khalek merged commit 3bfadcc into feature/llm-scan Oct 25, 2023
14 checks passed
@rabah-khalek rabah-khalek deleted the feature/gsk-1819-set-a-minimum-on-langchains-version branch October 25, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rabah-khalek rabah-khalek rabah-khalek approved these changes

Assignees

@Hartorn Hartorn

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hartorn @rabah-khalek