Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Github action to regenerate Lockfile #1506

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Adding Github action to regenerate Lockfile #1506

merged 4 commits into from
Oct 27, 2023

Conversation

Hartorn
Copy link
Member

@Hartorn Hartorn commented Oct 25, 2023

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@Hartorn Hartorn added the Lockfile Temporary label to update pdm.lock label Oct 25, 2023
@Hartorn Hartorn requested a review from andreybavt October 25, 2023 13:46
@Hartorn Hartorn self-assigned this Oct 25, 2023
@Hartorn Hartorn force-pushed the handle-lock branch 4 times, most recently from dd797ae to 6cc79fb Compare October 25, 2023 14:47
@github-actions github-actions bot removed the Lockfile Temporary label to update pdm.lock label Oct 25, 2023
@Hartorn Hartorn marked this pull request as ready for review October 25, 2023 15:01
@Hartorn Hartorn requested a review from a team as a code owner October 25, 2023 15:01
andreybavt
andreybavt reviewed Oct 25, 2023
View reviewed changes
.github/workflows/lock-deps.yml

name: Lock dependencies
on:
pull_request:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be paths: pointing to pyproject.toml, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was basing it on a label, to regenerate the lockfile only on demand, either on PR, or by running the action.

andreybavt
andreybavt reviewed Oct 25, 2023
View reviewed changes
.github/workflows/lock-deps.yml
- name: Adding file
run: |
git add pdm.lock
git commit -m "Regenerating pdm.lock" --allow-empty
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why --allow-empty ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like it's fine to get an empty commit if the lock is already up to date, to show it's been regenerating either way

andreybavt
andreybavt reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@andreybavt andreybavt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally fine, I left a couple of comments

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Hartorn Hartorn mentioned this pull request Oct 26, 2023
Merged
11 tasks
@Hartorn Hartorn requested a review from Inokinoki October 27, 2023 07:40
@andreybavt andreybavt merged commit d9a388b into main Oct 27, 2023
14 checks passed
@andreybavt andreybavt deleted the handle-lock branch October 27, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreybavt andreybavt andreybavt approved these changes

@Inokinoki Inokinoki Awaiting requested review from Inokinoki

Assignees

@Hartorn Hartorn

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hartorn @andreybavt