Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSK-1509] Add tests for ML worker actors behind WebSocket #1504

Conversation

Inokinoki
Copy link
Member

@Inokinoki Inokinoki commented Oct 25, 2023

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@linear
Copy link

linear bot commented Oct 25, 2023

GSK-1509 Add integration tests for WebSocket communication

  1. Java side integration test

    create a WebSocket endpoint, use a fake WebSocket connection to connect and test

  2. Python-Java integration test

    replace callbacks with mock function, use test-container to create a backend. use ~requests~ to call Web interface, then assert the messages received

  3. Python integration test

    how to test the implementations in listener.py ? - (testing with tests.utils.MockedClient should work)

…-1509-add-integration-tests-for-websocket-communication
@Inokinoki
Copy link
Member Author

Depending on #1535

@Inokinoki Inokinoki changed the title WIP [GSK-1509] Add tests for ML worker actors behind WebSocket [GSK-1509] Add tests for ML worker actors behind WebSocket Nov 3, 2023
@Inokinoki Inokinoki marked this pull request as ready for review November 3, 2023 10:02
@Inokinoki Inokinoki requested a review from Hartorn November 6, 2023 09:26
Copy link

sonarqubecloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@Hartorn Hartorn merged commit 5a62f9b into main Nov 6, 2023
16 checks passed
@Hartorn Hartorn deleted the feature/gsk-1509-add-integration-tests-for-websocket-communication branch November 6, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants