GSK-1863 : Using multiprocess instead of threading #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSK-1863 Using get similar examples on Enron seems to stuck the server/worker ?
Getting the insights on Enron is really slow, but whenclicking on get similar data, it looks like is getting stuck on some computations ? CPU usage is not that high, using only 1 cpu |
Hartorn
force-pushed
the
feature/gsk-1863-using-get-similar-examples-on-enron-seems-to-stuck-the
branch
from
11d7440 to
44191d5
Compare
Hartorn
changed the title
Hartorn
force-pushed
the
feature/gsk-1863-using-get-similar-examples-on-enron-seems-to-stuck-the
branch
5 times, most recently
from
ac378ad to
8a8edf2
Compare
Inokinoki
previously requested changes
Oct 11, 2023
andreybavt
reviewed
Oct 11, 2023
andreybavt
reviewed
Oct 11, 2023
| # Post-processing of stopWorker | ||
| if action == MLWorkerAction.stopWorker and ml_worker.ws_stopping is True: | ||
| ml_worker.ws_conn.disconnect() | ||
| return | ||
|
|
||
|
|
||
| def websocket_actor(action: MLWorkerAction): |
There was a problem hiding this comment.
Did you decide not to add a execute_in_pool boolean flag to this decorator?
There was a problem hiding this comment.
Good idea for some quick and short task
There was a problem hiding this comment.
Yeah, I forgot about that since I had issues with the enron. Just added
andreybavt
reviewed
Oct 11, 2023
| logger.debug(f'Registered "{callback.__name__}" for ML Worker "{action.name}"') | ||
|
|
||
| def wrapped_callback(ml_worker: MLWorker, req: dict, *args, **kwargs): | ||
| dispatch_action(callback, ml_worker, action, req) |
There was a problem hiding this comment.
in case execute_in_pool is added it would need to be passed here
andreybavt
reviewed
Oct 11, 2023
Hartorn
force-pushed
the
feature/gsk-1863-using-get-similar-examples-on-enron-seems-to-stuck-the
branch
from
8a8edf2 to
c821df9
Compare
Contributes to #GSK-1863
Hartorn
force-pushed
the
feature/gsk-1863-using-get-similar-examples-on-enron-seems-to-stuck-the
branch
from
c821df9 to
5dc0701
Compare
|
Kudos, SonarCloud Quality Gate passed! |
andreybavt
approved these changes
Oct 12, 2023
Hartorn
deleted the
feature/gsk-1863-using-get-similar-examples-on-enron-seems-to-stuck-the
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Type of Change
Checklist
CODE_OF_CONDUCT.mddocument.CONTRIBUTING.mdguide.make codestyle.