Rename unify to matching, convert state types to records #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NatKarmios
commented
Feb 12, 2024
NatKarmios
commented
- Resolves Rename Unification to Matching #196
- Resolves Inline records for complicated types #3
giltho
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Before merging I'd like to run bi-abduction and check that the results are those we had in the CSE paper, the rewriting you made is quite error-prone given state and af state are the same type, and that can cause spurious bugs e.g. when using record update syntax
(we tested, and it's consistent with master) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.