Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to OCaml 5 #276

Merged
merged 5 commits into from
Feb 7, 2024
Merged

Upgrade to OCaml 5 #276

merged 5 commits into from
Feb 7, 2024

Conversation

NatKarmios
Copy link
Contributor

@NatKarmios NatKarmios commented Feb 1, 2024 •
edited
Loading

  • Resolve dependencies
  • Make compilation succeed
  • Make tests pass
  • Remake githook scripts (shexp has been replaced with bos feather)

Note that older versions of esy will break during dependency resolution. Currently confirmed to work on version 0.7.2.

@NatKarmios NatKarmios requested a review from giltho February 4, 2024 10:31
giltho
giltho approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@giltho giltho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly minor :o

@NatKarmios NatKarmios merged commit c16736f into master Feb 7, 2024
9 checks passed
@NatKarmios NatKarmios deleted the ocaml5 branch February 7, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giltho giltho giltho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NatKarmios @giltho