Skip to content

Commit

Permalink
Created dist
Browse files Browse the repository at this point in the history
  • Loading branch information
Gillardo committed Jan 12, 2017
1 parent a82d16c commit 052bc1a
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion bower.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "bootstrap-ui-datetime-picker",
"version": "2.4.4",
"version": "2.5.0",
"homepage": "https://github.com/Gillardo/bootstrap-ui-datetime-picker",
"authors": [
"Gillardo <[email protected]>"
Expand Down
4 changes: 1 addition & 3 deletions dist/datetime-picker.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// https://github.com/Gillardo/bootstrap-ui-datetime-picker
// Version: 2.4.4
// Released: 2016-11-01
// Released: 2017-01-12
angular.module('ui.bootstrap.datetimepicker', ['ui.bootstrap.dateparser', 'ui.bootstrap.position'])
.constant('uiDatetimePickerConfig', {
dateFormat: 'yyyy-MM-dd HH:mm',
Expand Down Expand Up @@ -679,5 +679,3 @@ angular.module('ui.bootstrap.datetimepicker').run(['$templateCache', function($t
);

}]);

module.exports = 'ui.bootstrap.datetimepicker'

This comment has been minimized.

Copy link
@intgr

intgr Jan 12, 2017

Erm? So then why did you merge PR #167?

This comment has been minimized.

Copy link
@Gillardo

Gillardo Jan 12, 2017

Author Owner

Because someone wanted to be able to use it with require... Is it causing issues?

#167

This comment has been minimized.

Copy link
@intgr

intgr Jan 12, 2017

No, but this commit removed the two lines added in that pull request. :)

This comment has been minimized.

Copy link
@Gillardo

Gillardo Jan 12, 2017

Author Owner

Ah... so module.exports = 'ui.bootstrap.datetimepicker' isnt there anymore?

This comment has been minimized.

Copy link
@intgr

intgr Jan 13, 2017

Yes. Though it doesn't matter to me, I just happened look at the changes and noticed this.

This comment has been minimized.

Copy link
@hendrul

hendrul Jan 18, 2017

Can you add this line again pls?, this is the convention when working angular with module loaders (browserify or webpack)

Loading

2 comments on commit 052bc1a

@Gillardo
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but whoever created the PR did this incorrectly. I have now added this using a grunt task which adds the line to the dist file

@Gillardo
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just released version 2.5.1 with this fix

Please sign in to comment.