Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: #![deny(clippy::all)] #156

Merged
merged 6 commits into from
Dec 21, 2024
Merged

chore: #![deny(clippy::all)] #156

merged 6 commits into from
Dec 21, 2024

Conversation

KisaragiEffective
Copy link
Member

close #155

@m1sk9
Copy link
Member

m1sk9 commented Dec 21, 2024 •
edited
Loading

clippy って実は何も設定しないと警告しない?

@KisaragiEffective
Copy link
Member Author

そうだよ

@m1sk9
Copy link
Member

m1sk9 commented Dec 21, 2024 •
edited
Loading

そうだよ

あの JavaScript のエコシステム (ESLint) のほうがまだ利口なこと，あるんだ 😢

@KisaragiEffective
Copy link
Member Author

ESLintだって設定しないと動かないだろ

@m1sk9
Copy link
Member

m1sk9 commented Dec 21, 2024

ESLintだって設定しないと動かないだろ

ルール設定しなくてもデフォルトで五月蝿い気がするけど気の所為カ....

m1sk9
m1sk9 approved these changes Dec 21, 2024
View reviewed changes
Copy link
Member

@m1sk9 m1sk9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KisaragiEffective
Copy link
Member Author

ログ見たらsquashされてるんだけどsquashのほうが好み？

@KisaragiEffective
Copy link
Member Author

まあどうでもいいコミットだしsquash and mergeする

@KisaragiEffective KisaragiEffective merged commit 06fc347 into main Dec 21, 2024
1 check passed
@KisaragiEffective KisaragiEffective deleted the clippy branch December 21, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m1sk9 m1sk9 m1sk9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

main.rsに#![deny(clippy::all)]
2 participants
@KisaragiEffective @m1sk9