Fix incorrect keyboard shortcut actions in popups #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using keyboard shortcuts in popups an incorrect value is often returned from poll(), causing the wrong action to be taken. The problem is that an "active button index" is returned rather than the expected "absolute button index". Refactored code to return the correct value in all situations. Bug reproduction: 1. Navigate to a random file you want to delete 2. Hit Enter 3. Select "Delete" 4. When you get the "Are you sure?" question pop, press the "Y" key on the keyboard - and you will see the file NOT being deleted 5. Try again, but press the "N" key, and the file WILL (incorrectly) be deleted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR covers the half of what still remains after #440 was closed.
When using keyboard shortcuts in popups an incorrect value is often returned from poll(), causing the wrong action to be taken.
The problem is that an "active button index" is returned rather than the expected "absolute button index".
Refactored code to return the correct value in all situations.
Bug reproduction:
Navigate to a random file you want to delete
Hit Enter
Select "Delete"
When you get the "Are you sure?" question pop, press the "Y" key on the keyboard - and you will see the file NOT being deleted
Try again, but press the "N" key, and the file WILL (incorrectly) be deleted