-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improvements for the theming scheme of the SDK #1499
Merged
kristian-mkd
merged 23 commits into
PBE-5855-feat/react-native-video-design-v2
from
PBE-5856-feat/theme-consolidation
Oct 7, 2024
Merged
feat: improvements for the theming scheme of the SDK #1499
kristian-mkd
merged 23 commits into
PBE-5855-feat/react-native-video-design-v2
from
PBE-5856-feat/theme-consolidation
Oct 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristian-mkd
commented
Sep 30, 2024
kristian-mkd
commented
Sep 30, 2024
oliverlaz
reviewed
Sep 30, 2024
packages/react-native-sdk/src/components/Call/CallControls/internal/ReactionsPicker.tsx
Outdated
Show resolved
Hide resolved
packages/react-native-sdk/src/components/Call/CallControls/CallControlsButton.tsx
Outdated
Show resolved
Hide resolved
packages/react-native-sdk/src/components/Call/CallControls/CallControlsButton.tsx
Outdated
Show resolved
Hide resolved
sample-apps/react-native/dogfood/src/components/ParticipantActions.tsx
Outdated
Show resolved
Hide resolved
santhoshvai
reviewed
Sep 30, 2024
packages/react-native-sdk/src/components/Call/CallControls/ToggleCameraFaceButton.tsx
Outdated
Show resolved
Hide resolved
santhoshvai
reviewed
Sep 30, 2024
packages/react-native-sdk/src/components/Call/CallControls/ToggleAudioPublishingButton.tsx
Outdated
Show resolved
Hide resolved
santhoshvai
reviewed
Sep 30, 2024
kristian-mkd
commented
Oct 1, 2024
...act-native-sdk/src/components/Livestream/LivestreamControls/LivestreamAudioControlButton.tsx
Show resolved
Hide resolved
kristian-mkd
commented
Oct 1, 2024
kristian-mkd
changed the base branch from
main
to
PBE-5855-feat/react-native-video-design-v2
October 1, 2024 14:07
santhoshvai
reviewed
Oct 4, 2024
santhoshvai
reviewed
Oct 4, 2024
Comment on lines
+367
to
+369
margin: 10, | ||
padding: 10, | ||
fontSize: 16, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do make sure that all margins, padding, sizes also move to theme when we move to design v2
santhoshvai
approved these changes
Oct 7, 2024
kristian-mkd
merged commit Oct 7, 2024
e7b86b6
into
PBE-5855-feat/react-native-video-design-v2
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π― Goal
π Implementation details
β theme color and options are improved
β new variants added (fontSizes, spacingSizes)
β new defaults added
β
colorPalette
usages in the SDK are removedβ
darkColors
are removed from SDK, so only one set of colors present in base themeβ new alternative
theme.get(componentOrPath: string, prop?: keyof Theme['defaults'] | string)
method added with unit test coverageTBD: π§ In the next tasks from the Design v2 provide additional fixes in the dogfood app
Table with the color name changes for easier reviewing:
π¨ UI Changes
iOS
Android
π§ͺ Testing
βοΈ Checklist
develop
branch