Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improvements for the theming scheme of the SDK #1499

Conversation

kristian-mkd
Copy link
Contributor

@kristian-mkd kristian-mkd commented Sep 26, 2024

🎯 Goal

  • Jira Ticket: PBE-5856
  • consolidate and improve the theming options of the SDK

πŸ›  Implementation details

βœ… theme color and options are improved
βœ… new variants added (fontSizes, spacingSizes)
βœ… new defaults added
βœ… colorPalette usages in the SDK are removed
βœ… darkColors are removed from SDK, so only one set of colors present in base theme
βœ… new alternative theme.get(componentOrPath: string, prop?: keyof Theme['defaults'] | string) method added with unit test coverage

TBD: 🚧 In the next tasks from the Design v2 provide additional fixes in the dogfood app

Table with the color name changes for easier reviewing:

old name new name value
static_white base1 palette.grey50
borders base2 palette.grey300
text_low_emphasis base3 palette.grey500
static_gray base4 palette.grey700
static_black base5 palette.grey950
dark.conent_bg background1 palette.grey950 + opacityToHex(0.05)
dark_gray background2 palette.grey800
overlay background3 palette.grey950 + opacityToHex(0.4)
overlay_dark background4 palette.grey950 + opacityToHex(0.6)
dark.bars & dark.controls_bg background5 palette.grey900
static_overlay background6 palette.grey950 + opacityToHex(0.85)
dark.text_high_emphasis base1 palette.grey50
dark.borders base4 palette.grey700
dark.overlay background3 palette.grey950 + opacityToHex(0.4)

🎨 UI Changes

iOS
Before After
Android
Before After

πŸ§ͺ Testing

β˜‘οΈ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@kristian-mkd kristian-mkd marked this pull request as draft September 26, 2024 13:00
@kristian-mkd kristian-mkd marked this pull request as ready for review October 1, 2024 14:01
@kristian-mkd kristian-mkd changed the base branch from main to PBE-5855-feat/react-native-video-design-v2 October 1, 2024 14:07
Comment on lines +367 to +369
margin: 10,
padding: 10,
fontSize: 16,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do make sure that all margins, padding, sizes also move to theme when we move to design v2

@kristian-mkd kristian-mkd merged commit e7b86b6 into PBE-5855-feat/react-native-video-design-v2 Oct 7, 2024
12 checks passed
@kristian-mkd kristian-mkd deleted the PBE-5856-feat/theme-consolidation branch October 7, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants