Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHA-14] Added support for pinning, archiving channels and partial member update #293

Merged
merged 6 commits into from
Dec 4, 2024
Merged

[CHA-14] Added support for pinning, archiving channels and partial member update #293

merged 6 commits into from
Dec 4, 2024

Conversation

totalimmersion
Copy link
Contributor

@totalimmersion totalimmersion force-pushed the feature/cha-14_custom_data_pinning_archiving branch from 961fa23 to 4eed979 Compare December 4, 2024 10:04
akupila
akupila reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@akupila akupila left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only adds support for pinning, so we should probably exclude ArchivedAt (or also add that here, as it's very similar)

channel.go Outdated Show resolved Hide resolved
@totalimmersion totalimmersion force-pushed the feature/cha-14_custom_data_pinning_archiving branch from 4eed979 to 642da3e Compare December 4, 2024 10:16
@totalimmersion totalimmersion marked this pull request as draft December 4, 2024 10:22
@totalimmersion totalimmersion force-pushed the feature/cha-14_custom_data_pinning_archiving branch 9 times, most recently from e339869 to 17fb0b7 Compare December 4, 2024 12:45
@totalimmersion totalimmersion force-pushed the feature/cha-14_custom_data_pinning_archiving branch from 17fb0b7 to fcfd18b Compare December 4, 2024 13:30
@totalimmersion totalimmersion changed the title [CHA-14] Added support for pinning / unpinning channels [CHA-14] Added support for pinning, archiving channels and partial member update Dec 4, 2024
@totalimmersion totalimmersion marked this pull request as ready for review December 4, 2024 14:20
akupila
akupila previously approved these changes Dec 4, 2024
View reviewed changes
channel_test.go Outdated Show resolved Hide resolved
channel_test.go Outdated Show resolved Hide resolved
totalimmersion and others added 2 commits December 4, 2024 16:46
@totalimmersion @akupila
fix: update channel_test.go
7c9d952 
Co-authored-by: Antti Kupila <[email protected]>
@totalimmersion @akupila
fix: update channel_test.go
426e4f8 
Co-authored-by: Antti Kupila <[email protected]>
@totalimmersion totalimmersion force-pushed the feature/cha-14_custom_data_pinning_archiving branch from 7df2729 to 426e4f8 Compare December 4, 2024 15:47
@totalimmersion totalimmersion merged commit b2fd181 into master Dec 4, 2024
8 checks passed
@totalimmersion totalimmersion deleted the feature/cha-14_custom_data_pinning_archiving branch December 4, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akupila akupila akupila approved these changes

@JimmyPettersson85 JimmyPettersson85 Awaiting requested review from JimmyPettersson85 JimmyPettersson85 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@totalimmersion @akupila