Make beforecreate hooks static functions #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dafeder I struggled to merge the HHS dkan customization and I think that this step is actually a bug in the upstream version. I ended up having to change it to @BeforeEntityCreateScope in order to have HHS tests pass. https://github.com/NuCivic/dkanextension/pull/61/files#diff-b27d85214e36cbc69430a94630a856a4L173 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the last update of the dkanextention, the corresponding behat upgrade broke a number of tests due to errors about the hook functions being called non-statically. Ultimately we rolled back the behat version and this PR, but I'm resubmitting for reference when we ultimately do update behat.
I'm not completely convinced that this is the fix that's necessary. The hooks in questions seem to be step hooks, and according to the behat documentation should not be static. So the problem may lie in something about the scope definition, not the hook functions themselves.