Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add download_iau2000_file() #56

Merged
merged 10 commits into from
Oct 4, 2024
Merged

Add download_iau2000_file() #56

merged 10 commits into from
Oct 4, 2024

Conversation

EugeneDu-GA
Copy link
Collaborator

Add download_iau2000_file() and other improvements

@EugeneDu-GA EugeneDu-GA self-assigned this Sep 19, 2024
ronaldmaj
ronaldmaj requested changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@ronaldmaj ronaldmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. The changes to the attempt_download function look ok, but we'll need to make sure that all functions that rely on it are ok

gnssanalysis/gn_download.py Show resolved Hide resolved
gnssanalysis/gn_download.py Outdated Show resolved Hide resolved
gnssanalysis/gn_download.py Outdated Show resolved Hide resolved
ronaldmaj
ronaldmaj requested changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@ronaldmaj ronaldmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good, thanks for addressing my previous comments. Just a formatting issue I found in that the line length seems not to be set at 120? After that I think this can go in

gnssanalysis/gn_download.py Outdated Show resolved Hide resolved
gnssanalysis/gn_download.py Outdated Show resolved Hide resolved
ronaldmaj
ronaldmaj approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@ronaldmaj ronaldmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for fixing up the formatting. I think this is good to go in now

@ronaldmaj ronaldmaj merged commit e75759e into main Oct 4, 2024
4 checks passed
@ronaldmaj ronaldmaj deleted the gn_download-fixing branch October 4, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldmaj ronaldmaj ronaldmaj approved these changes

@seballgeyer seballgeyer Awaiting requested review from seballgeyer

Assignees

@EugeneDu-GA EugeneDu-GA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EugeneDu-GA @ronaldmaj