Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPI-3446 Fix SP3 parse and write of data section flags, plus address CLK and POS nodata causing misalignment #45

Merged

Commits on Aug 13, 2024

  1. NPI-3446 various bugfixes in sp3 parse and write:

    - fixed incorrect width of unused columns between data flag values (2 instead of 1). This allows the second prediction flag to be read in.
    - Consolidated definitions of columns for maintainability.
    - Updated column/index definitions to clearly define a FLAGS index, and specify names of individual flag columns.
    - Fixed SP3 output generator to access and output FLAGS data.
    - Addressed misalignment bug caused by the combination of CLK nodata value width, and Pandas adding a space between columns. Also applied this fix to POS nodata value, as it appears the same issue would apply there.
    - Added handling for missing flag values (conformance to empty strings to avoid outputting nans)
    - Added placeholder TODOs for throwing exceptions if record types are encountered that we currently do not implement support for (EP, EV).
    treefern committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    f9ab891 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. NPI-3446 Fix SP3 writing of FLAGS columns using pre-concatenation to …

    …avoid DataFrame.to_string() inserting spaces.
    treefern committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    f4170e1 View commit details
    Browse the repository at this point in the history
  2. NPI-3446 Remove deprecated argument to dataframe groupby(). Value use…

    …d has same effect as default.
    treefern committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    2f51ab6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9f33165 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. NPI-3446 Add raw flag to escaped string definitions to make linter ha…

    …ppy. (Note that it seems to still work without this)
    treefern committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    8773a23 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d4d5dd1 View commit details
    Browse the repository at this point in the history