Npi 3430 Fix SP3 header parsing to more robustly handle orbit accuracy values #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odes. More doc and unit tests to come
…ndle negative integers
|
Further commentary, more minor fixes, and unit tests to be added in another PR. |
ronaldmaj
approved these changes
Aug 2, 2024
treefern
commented
Aug 14, 2024
|
|
||
| # Regex for orbit accuracy codes (E.g. ' 15' - space padded, blocks are three chars wide). | ||
| # Note: header is padded with ' 0' entries after the actual data, so empty fields are matched and then trimmed. | ||
| _RE_SP3_HEADER_ACC = _re.compile(rb"^\+{2}[ ]+((?:[\-\d\s]{2}\d){17})$", _re.MULTILINE) |
There was a problem hiding this comment.
It turns out the use of the trailing $ here was a mistake. Not all SP3 files have the line ending immediately after the orbit accuracy codes. Some pad with spaces. This is resolved in #45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation searched for a slightly incorrect length of data (50 instead of 51 chars), and did this instead of explicitly specifying the expected format (three char chunks which always end with a digit). It also did not allow for
-, leading negative values to crash the SP3 header parser.