Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multichannel interfaces #78

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix multichannel interfaces #78

wants to merge 2 commits into from

Conversation

boomlinde
Copy link

This implements

  • A bug fix causing pulsemixer not to work with devices with more than 8 channels
  • A QoL feature for such audio interfaces: always displaying the channel number

@boomlinde
Support multi-channel interfaces
a48d673 
Prior to this commit, if a device with more than eight channels appeared
in a device list, only the first eight channels were actually displayed.
Devices below the multi-channel device were not displayed.

The issue relates to the naming of channels; they were given names
depending on their channel number, which works well for up to eight
channels. When the 9th channel appeared, it was considered to be
Bar.NONE, which caused its name to be displayed in the center of the
screen. Then, retreiving the name caused an exception, which caused the
remaining devices not to be displayed.

The solution is to give Bar.NONE a value that can't possibly be confused
for a channel index, and to default to displaying the channel number if
there is no name for the channel.
@boomlinde
Always display non-mono channel numbers
6007740 
Prior to this commit, channel numbers were only displayed if there was
no name for the channel, defined in Screen.SIDES. In reality, channels
numbers don't necessarily correspond to a speaker function, e.g. in a
music studio context. Then it's more useful to know the actual channel
number.

With this commit, channel numbers are always displayed, with the speaker
side name displayed if available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@boomlinde