Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSLUX-639: Export style panel #166

Merged
merged 5 commits into from
Oct 24, 2024
Merged

GSLUX-639: Export style panel #166

merged 5 commits into from
Oct 24, 2024

Conversation

tkohr
Copy link
Contributor

@tkohr tkohr commented Oct 22, 2024

JIRA issue

https://jira.camptocamp.com/browse/GSLUX-639

Description

PR exports the style panel for integration in v3 and removes a condition in v4 app that does not seem necessary anymore.

Copy link
Contributor

GitHub Pages links: * Luxembourg-geoportail: https://geoportail-luxembourg.github.io/luxembourg-geoportail/GSLUX-639-style-panel-export/

@AlitaBernachot
Copy link
Contributor

AlitaBernachot commented Oct 23, 2024

Thx for the work! I found a minor bug (tested on github pages): I can open style editor panel and catalog panel at the same time (clicking on the theme icon in the header), but I don't think this is related to your work.
image

@tkohr
Copy link
Contributor Author

tkohr commented Oct 23, 2024

Good catch, I've added a commit to fix this issue :-)

@tkohr
Copy link
Contributor Author

tkohr commented Oct 23, 2024

And one for fixing a similar issue in v3 (where the style panel did not open anymore once the theme grid had been opened).

@tkohr tkohr merged commit c3cc294 into main Oct 24, 2024
2 checks passed
@tkohr tkohr deleted the GSLUX-639-style-panel-export branch October 24, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants