GSLUX-749: Auto auth with cookies and adapt for v3 #165
Conversation
|
GitHub Pages links: * Luxembourg-geoportail: https://geoportail-luxembourg.github.io/luxembourg-geoportail/GSLUX-749-auth-finalize/ |
There was a problem hiding this comment.
Nice @AlitaBernachot, thanks for the clean PR!
Authentication works within the v3 docker composition using the lib, but I get CORS errors in v4 using v3 as the backend:
May there something be missing regarding ALLOW_CORS=1 in your other PR? Or may I have missed something 😄 ?
| @@ -9,7 +9,7 @@ | |||
| "build": "run-p type-check build-only", | |||
| "build-only": "vite build", | |||
| "build:lib:prod": "npx vite build --mode prod --config vite-dist.config.ts --minify=esbuild --debug && npx babel bundle/lux.dist.mjs --out-file bundle/lux.dist.js", | |||
| "build:lib:dev": "npx vite build --mode staging --config vite-dist.config.ts --minify=false --base=/dev/main.html/ --debug && cp bundle/lux.dist.mjs bundle/lux.dist.js", | |||
| "build:lib:dev": "npx vite build --mode staging --config vite-dist.config.ts --minify=false --base=/dev/main.html/ --debug && BABEL_ENV=dev npx babel bundle/lux.dist.mjs --out-file bundle/lux.dist.js", | |||
There was a problem hiding this comment.
Ok so I just noticed that this is essential for the lib build to work in v3 once the updates in https://github.com/Geoportail-Luxembourg/luxembourg-geoportail/pull/163/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 are installed (cc @mki-c2c, @tonio, so you don't fall in the same trap I did)
JIRA issue
https://jira.camptocamp.com/browse/GSLUX-749
Description
Finalize auth form component.