Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSLUX-747: Auth form ui #160

Merged
merged 2 commits into from
Oct 16, 2024
Merged

GSLUX-747: Auth form ui #160

merged 2 commits into from
Oct 16, 2024

Conversation

AlitaBernachot
Copy link
Contributor

@AlitaBernachot AlitaBernachot commented Oct 14, 2024 •
edited
Loading

JIRA issue

https://jira.camptocamp.com/browse/GSLUX-747

Description

  • new dropdown content component, now dropdown list component inherits dropdown content component
  • new auth form component

Screenshots

image

@github-actions GitHub Actions
Copy link
Contributor

GitHub Pages links: * Luxembourg-geoportail: https://geoportail-luxembourg.github.io/luxembourg-geoportail/GSLUX-747-auth-ui/

@AlitaBernachot AlitaBernachot force-pushed the GSLUX-747-auth-ui branch 2 times, most recently from 786b56e to 8133e28 Compare October 15, 2024 12:39
@AlitaBernachot AlitaBernachot marked this pull request as ready for review October 15, 2024 13:25
tkohr
tkohr approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @AlitaBernachot! Code LGTM.

The UI is not pixel perfect with prod, but close enough IMO.

I just noticed that the language and auth dropdowns are not exclusive and that you can open both at the same time. Maybe you can still fix this.

@AlitaBernachot
Copy link
Contributor Author

The UI is not pixel perfect with prod, but close enough IMO.

Oops yes, I will rework a bit more to be closer to the prod display. Also I found the submit button and the placeholders, are not the same color.

I just noticed that the language and auth dropdowns are not exclusive and that you can open both at the same time. Maybe you can still fix this.

Good point, will fix this.

@AlitaBernachot AlitaBernachot merged commit 24874eb into main Oct 16, 2024
2 checks passed
@AlitaBernachot AlitaBernachot deleted the GSLUX-747-auth-ui branch October 16, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkohr tkohr tkohr approved these changes

@mki-c2c mki-c2c Awaiting requested review from mki-c2c

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlitaBernachot @tkohr