-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSLUX-737: Export drawn feature as gpx, kml and shapefile #156
Conversation
GitHub Pages links: * Luxembourg-geoportail: https://geoportail-luxembourg.github.io/luxembourg-geoportail/GSLUX-737-export-feat/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clean architecture and the unit tests @AlitaBernachot!
PR LGTM, only thing I noticed testing is that production also exports feature properties in a <ExtendedData>
tag within KML, not shapefile though. So I don't know if it's relevant.
There are |
@tkohr after checking with the client, it is possible to import kml but you need to login first and use MyMaps. Since this is related to MyMaps functionality, I suggest to handle this during the dev for MyMaps (https://camptocamp.atlassian.net/browse/GSLUX-710). |
76d8cf6
to
56998af
Compare
@tkohr just tested adding random custom property to the feature (eg. |
56998af
to
9e20a7c
Compare
JIRA issue
https://jira.camptocamp.com/browse/GSLUX-737
Description
Export drawn feature as gpx, kml and shapefile + fix export gpx for circle and polygon (does not work in prod).
Export gpx and kml does not call api anymore.
NB. use chrome plugin for CORS policy when exporting to shapefile (you need v3 running on localhost:8080)