Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSLUX-744 Feature measurements #155

Merged
merged 8 commits into from
Oct 14, 2024
Merged

GSLUX-744 Feature measurements #155

merged 8 commits into from
Oct 14, 2024

Conversation

tkohr
Copy link
Contributor

@tkohr tkohr commented Oct 7, 2024

JIRA issue

https://jira.camptocamp.com/browse/GSLUX-744

Description

PR calculates and updates the measurements of a drawn/edited feature.

It also adds two dependencies:

  • cypress-real-events: for better testing of openlayers actions on the map
  • eslint-plugin-no-only-tests: to prevent forgetting onlys in test suites

To-dos:

  • Get elevation for points
  • Calculate radius and adapt length and area calculation for circle (once it is managed as a circle geometry) => depends on GSLUX-743 and will be done in GSLUX-743: Modify circle geometries #159

circle will likely still be adapted once it's not managed as a polygon anymore
adds real events plugin for tests on ol map
adds es lint plugin to check for 'only' in e2e tests
Copy link
Contributor

github-actions bot commented Oct 7, 2024

@tkohr tkohr marked this pull request as ready for review October 8, 2024 15:21
@tkohr tkohr force-pushed the GSLUX-744-calculate-dimensions branch from 8aba2e8 to c675016 Compare October 9, 2024 15:07
Copy link
Contributor

@AlitaBernachot AlitaBernachot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great thanks (did not test elevation for point because I tested the github pages, but code looks ok).

Maybe extract formating (in feat.measurement helper or from measurements.utils) to have the code for formatting text in the same place?

@tkohr tkohr mentioned this pull request Oct 11, 2024
5 tasks
@tkohr tkohr merged commit 78640cc into main Oct 14, 2024
2 checks passed
@tkohr tkohr deleted the GSLUX-744-calculate-dimensions branch October 14, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants