Gslux 705 modify feature selection and sync between map and UI #148
Conversation
|
all tests are fixed, would be good to merge this also. |
mki-c2c
changed the title
mki-c2c
changed the base branch from
GSLUX-704-draw-end
to
GSLUX-704-fix_tests
mki-c2c
changed the base branch from
GSLUX-704-fix_tests
to
GSLUX-704-draw-end
| // opening the last item is directly done in addDrawnFeature in draw store via activeFeatureId | ||
| /* watch( | ||
| * features, | ||
| * (newFeatures, oldFeatures) => { | ||
| * // Last added feature is unfold by default | ||
| * if (oldFeatures === undefined || newFeatures.length > oldFeatures.length) { | ||
| * const currentFeature = | ||
| * newFeatures[oldFeatures === undefined ? 0 : newFeatures.length - 1] | ||
| * // currentOpenedFeature.value = currentEditingFeature.value = | ||
| * currentFeature.id | ||
| * } | ||
| * }, | ||
| * { immediate: true } | ||
| * ) | ||
| * */ |
There was a problem hiding this comment.
I guess we can get rid of this here then.
| // const drawnFeatureToFeature = function ( | ||
| // drawnFeature: DrawnFeature | ||
| // ): Feature<Geometry> { | ||
| // const olFeature = drawnFeature.olFeature | ||
| // olFeature.set('name', drawnFeature.label) | ||
| // return olFeature | ||
| // } | ||
|
|
There was a problem hiding this comment.
Can we also delete the commented lines below in featuresToUrl?
| @@ -35,6 +36,8 @@ class StatePersistorFeaturesService implements StatePersistorService { | |||
|
|
|||
| restore() { | |||
| const { drawnFeatures } = storeToRefs(useDrawStore()) | |||
| // initialise map listeners for feature selection | |||
| useDrawSelect() | |||
There was a problem hiding this comment.
It feels a little strange to call a composable in a state persistor, but I agree that it makes sense to concentrate this logic in a composable and don't have a better suggestion neither.
Yes, I would also like to see the other PR merged first. On my local server, the selected labels appear bigger. We can check it with the CD version before merging into main |
|
GitHub Pages links: * Luxembourg-geoportail: https://geoportail-luxembourg.github.io/luxembourg-geoportail/GSLUX-705_modify_feature_rebased2/ |
start of work for selecting and editing features