GSLUX-733: Symbols #147
GSLUX-733: Symbols #147
Conversation
|
GitHub Pages links: * Luxembourg-geoportail: https://geoportail-luxembourg.github.io/luxembourg-geoportail/GSLUX-733-point-symbole/ |
AlitaBernachot
force-pushed
the
GSLUX-733-point-symbole
branch
4 times, most recently
from
b81ed39
to
05af2bf
Compare
AlitaBernachot
force-pushed
the
GSLUX-733-point-symbole
branch
2 times, most recently
from
994ea61
to
5f96327
Compare
AlitaBernachot
force-pushed
the
GSLUX-733-point-symbole
branch
from
5f96327
to
2c68677
Compare
AlitaBernachot
force-pushed
the
GSLUX-733-point-symbole
branch
from
f098f8a
to
9e05cf8
Compare
| # Paths for symbols | ||
| VITE_SYMBOL_ICONS_URL="https://map.geoportail.lu/mymaps" | ||
| VITE_SYMBOLS_URL="https://map.geoportail.lu/mymaps/symbols" |
There was a problem hiding this comment.
Shouldn't we rather use the migration URLs for dev and staging?
There was a problem hiding this comment.
It would be better I agree but there are currently CORS issues when calling https://migration.geoportail.lu/mymaps/symbols in dev, should I change to migration anyway? (it can be bypassed using a chrome plugin but you have to be aware of that. What do you think?
There was a problem hiding this comment.
I will merge as is for the demo, there is surely something to do with the url from migration/prod for the symbols, especially for the upload symbols functionality.
| inject('currentEditCompKey') | ||
| // const feature: DrawFeature | undefined = inject('feature') // TODO: | ||
| const featureShape: FeatureShape = 'circle' // feature.olFeature.get('shape') // TODO: to plug when feature ok | ||
| const featureColor = 'red' // feature.olFeature.get('color') // TODO: to plug when feature ok |
There was a problem hiding this comment.
This will be part of the logical part anyway, but did I understand right, that the problem of using DrawnFeature.featureStyle.color here is, that it currently needs a DrawnFeature.changed() call for ol to update it?
There was a problem hiding this comment.
Exactly, we should improve Drawnfeature class to avoid calling ol functionalities in our components.
AlitaBernachot
force-pushed
the
GSLUX-733-point-symbole
branch
from
0c14a8e
to
bfcca3f
Compare
JIRA issue
https://jira.camptocamp.com/browse/GSLUX-733
Description
Implement symbol edition for Point (UI only).