GSLUX-769: FIX for profile measures in v3 #3203
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlitaBernachot
force-pushed
the
GSLUX-769-fix-profile-measures
branch
2 times, most recently
from
300e794
to
d76d7cb
Compare
AlitaBernachot
force-pushed
the
GSLUX-769-fix-profile-measures
branch
from
d76d7cb
to
0dc4b0e
Compare
tkohr
approved these changes
Dec 4, 2024
| @@ -24,10 +24,10 @@ | |||
| </div> | |||
| </div> | |||
| <span ng-show="ctrl.featureElevation" translate>Elevation: {{ ctrl.featureElevation }}</span> | |||
| <div class="feature-popup-profile" ng-show="ctrl.showFeatureProfile.active"> | |||
| <div class="feature-popup-profile" ng-if="ctrl.showFeatureProfile.active"> <!-- us-ng-if otherwise profile is duplicated in dom... --> | |||
There was a problem hiding this comment.
Suggested change
| <div class="feature-popup-profile" ng-if="ctrl.showFeatureProfile.active"> <!-- us-ng-if otherwise profile is duplicated in dom... --> | |
| <div class="feature-popup-profile" ng-if="ctrl.showFeatureProfile.active"> <!-- use ng-if otherwise profile is duplicated in dom... --> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue
https://jira.camptocamp.com/browse/GSLUX-769
Description
Enable reset profile measures data (reset and show empty graph) when profile measure is reset/hidden/closed in v3.
NB. this PR needs Geoportail-Luxembourg/luxembourg-geoportail#177