Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix disabling fortran #740

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

tjhei
Copy link
Contributor

@tjhei tjhei commented Jun 5, 2024

I have fortran, but I am disabling it using WB_MAKE_FORTRAN_WRAPPER=OFF.

Without this patch I am getting

CMake Error: Error required internal CMake variable not set, cmake may not be built correctly.
Missing variable is:
CMAKE_Fortran_COMPILE_OBJECT

also see https://github.com/geodynamics/aspect/pull/5792/files

Copy link

github-actions bot commented Jun 5, 2024

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.015 ± 0.004 (s=463) 1.020 ± 0.004 (s=424) +0.4% .. +0.6%
Slab interpolation curved simple none 1.020 ± 0.005 (s=454) 1.025 ± 0.004 (s=429) +0.4% .. +0.6%
Spherical slab interpolation simple none 1.185 ± 0.006 (s=370) 1.187 ± 0.006 (s=391) +0.0% .. +0.3%
Slab interpolation simple curved CMS 1.059 ± 0.005 (s=407) 1.063 ± 0.006 (s=443) +0.3% .. +0.5%
Spherical slab interpolation simple CMS 1.591 ± 0.010 (s=263) 1.593 ± 0.013 (s=305) -0.1% .. +0.3%
Spherical fault interpolation simple none 1.187 ± 0.006 (s=388) 1.187 ± 0.006 (s=373) -0.2% .. +0.1%
Cartesian min max surface 2.306 ± 0.018 (s=204) 2.309 ± 0.018 (s=189) -0.2% .. +0.4%
Spherical min max surface 7.219 ± 0.032 (s=74) 7.224 ± 0.027 (s=53) -0.2% .. +0.3%

Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@MFraters MFraters merged commit a68f06e into GeodynamicWorldBuilder:main Jun 5, 2024
37 of 38 checks passed
@tjhei tjhei deleted the fix-fortran-off branch June 6, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants