Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add intel lstd++ linker flag. #703

Conversation

MFraters
Copy link
Member

Trying to compile on fronterra with the intel compiler gwb-grid didn't link with error messages stating many/all std functions where undefined. This pull request fixes that.

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (261c22b) to head (88691ef).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
+ Coverage   98.17%   98.21%   +0.03%     
==========================================
  Files         107      107              
  Lines        7463     7462       -1     
==========================================
+ Hits         7327     7329       +2     
+ Misses        136      133       -3     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 261c22b...88691ef. Read the comment docs.

Copy link

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.019 ± 0.008 (s=460) 1.019 ± 0.004 (s=426) -0.2% .. +0.1%
Slab interpolation curved simple none 1.016 ± 0.004 (s=438) 1.022 ± 0.003 (s=448) +0.5% .. +0.7%
Spherical slab interpolation simple none 1.168 ± 0.005 (s=387) 1.169 ± 0.006 (s=386) -0.1% .. +0.2%
Slab interpolation simple curved CMS 1.060 ± 0.004 (s=415) 1.060 ± 0.005 (s=436) -0.1% .. +0.1%
Spherical slab interpolation simple CMS 1.551 ± 0.009 (s=286) 1.551 ± 0.009 (s=297) -0.2% .. +0.1%
Spherical fault interpolation simple none 1.175 ± 0.005 (s=401) 1.174 ± 0.005 (s=368) -0.2% .. -0.0%
Cartesian min max surface 2.305 ± 0.019 (s=206) 2.304 ± 0.016 (s=187) -0.3% .. +0.2%
Spherical min max surface 7.212 ± 0.029 (s=60) 7.212 ± 0.029 (s=67) -0.2% .. +0.2%

@gassmoeller gassmoeller merged commit dbf0e2c into GeodynamicWorldBuilder:main May 3, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants