Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add WB_ENABLE_APP = OFF test. #693

Merged

Conversation

MFraters
Copy link
Member

@MFraters MFraters commented Mar 2, 2024

follow up to #686, adding a test for disabling the apps

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.23%. Comparing base (7a7066f) to head (d1cd3bb).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #693      +/-   ##
==========================================
- Coverage   98.24%   98.23%   -0.02%     
==========================================
  Files         107      107              
  Lines        7464     7464              
==========================================
- Hits         7333     7332       -1     
- Misses        131      132       +1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a7066f...d1cd3bb. Read the comment docs.

Copy link

github-actions bot commented Mar 2, 2024

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.022 ± 0.004 (s=432) 1.022 ± 0.005 (s=451) -0.1% .. +0.1%
Slab interpolation curved simple none 1.021 ± 0.006 (s=431) 1.024 ± 0.009 (s=452) +0.2% .. +0.5%
Spherical slab interpolation simple none 1.169 ± 0.007 (s=369) 1.169 ± 0.006 (s=403) -0.1% .. +0.2%
Slab interpolation simple curved CMS 1.057 ± 0.004 (s=430) 1.061 ± 0.004 (s=422) +0.2% .. +0.4%
Spherical slab interpolation simple CMS 1.552 ± 0.008 (s=290) 1.550 ± 0.010 (s=293) -0.2% .. +0.1%
Spherical fault interpolation simple none 1.173 ± 0.006 (s=395) 1.173 ± 0.006 (s=375) -0.2% .. +0.1%
Cartesian min max surface 2.321 ± 0.023 (s=184) 2.323 ± 0.025 (s=206) -0.3% .. +0.4%
Spherical min max surface 7.219 ± 0.029 (s=59) 7.214 ± 0.025 (s=68) -0.3% .. +0.2%

@MFraters MFraters merged commit 2361838 into GeodynamicWorldBuilder:main Mar 2, 2024
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant