Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new contributors to authors file. #682

Conversation

MFraters
Copy link
Member

Please let me know if I forgot anyone.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (5bce102) to head (ff521ee).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #682      +/-   ##
==========================================
- Coverage   98.30%   98.30%   -0.01%     
==========================================
  Files         107      107              
  Lines        7358     7357       -1     
==========================================
- Hits         7233     7232       -1     
  Misses        125      125              

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bce102...ff521ee. Read the comment docs.

Copy link

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.012 ± 0.004 (s=438) 1.018 ± 0.004 (s=451) +0.5% .. +0.7%
Slab interpolation curved simple none 1.015 ± 0.004 (s=436) 1.020 ± 0.003 (s=451) +0.5% .. +0.6%
Spherical slab interpolation simple none 1.170 ± 0.012 (s=391) 1.168 ± 0.006 (s=381) -0.3% .. +0.1%
Slab interpolation simple curved CMS 1.058 ± 0.004 (s=410) 1.055 ± 0.004 (s=444) -0.4% .. -0.3%
Spherical slab interpolation simple CMS 1.551 ± 0.009 (s=265) 1.551 ± 0.015 (s=318) -0.2% .. +0.2%
Spherical fault interpolation simple none 1.155 ± 0.014 (s=388) 1.156 ± 0.013 (s=393) -0.2% .. +0.3%
Cartesian min max surface 2.308 ± 0.021 (s=183) 2.306 ± 0.022 (s=210) -0.4% .. +0.2%
Spherical min max surface 7.217 ± 0.024 (s=67) 7.212 ± 0.027 (s=60) -0.3% .. +0.1%

@gassmoeller
Copy link
Contributor

Looks good to me.

@tjhei tjhei merged commit 545bb15 into GeodynamicWorldBuilder:main Feb 28, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants