Gwb grid limit resolution #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhei
approved these changes
Feb 17, 2024
source/gwb-grid/main.cc
Outdated
| @@ -363,7 +366,6 @@ int main(int argc, char **argv) | |||
| number_of_threads = Utilities::string_to_unsigned_int(options_vector[i+1]); | |||
| options_vector.erase(options_vector.begin()+static_cast<std::vector<std::string>::difference_type>(i)); | |||
| options_vector.erase(options_vector.begin()+static_cast<std::vector<std::string>::difference_type>(i)); | |||
| --i; | |||
There was a problem hiding this comment.
I am no longer convinced this is correct. I am too tired to figure out.
tests/CMakeLists.txt
Outdated
| @@ -256,7 +256,7 @@ file(GLOB_RECURSE COOKBOOK_TEST_SOURCES "${CMAKE_SOURCE_DIR}/cookbooks/*/*.wb") | |||
| foreach(test_source ${COOKBOOK_TEST_SOURCES}) | |||
| get_filename_component(test_name ${test_source} NAME_WE) | |||
| get_filename_component(test_dir ${test_source} DIRECTORY) | |||
| set(TEST_ARGUMENTS "${test_dir}/${test_name}.wb\;${test_dir}/${test_name}.grid") | |||
| set(TEST_ARGUMENTS "${test_dir}/${test_name}.wb\;${test_dir}/${test_name}.grid\;--resolution-limit\;75") | |||
There was a problem hiding this comment.
I am not sure 20 will be enough to ensure hitting any not huge feature in a model. 50?
MFraters
force-pushed
the
gwb-grid-limit-resolution
branch
from
053479b to
5eeb976
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #653 +/- ##
==========================================
+ Coverage 92.63% 92.68% +0.04%
==========================================
Files 98 98
Lines 6882 6888 +6
==========================================
+ Hits 6375 6384 +9
+ Misses 507 504 -3
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option to limit the resolution of gwb-grid, and applies that to the cookbook tester.