-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a simple subduction 2d chunk model cookbook #648
Add a simple subduction 2d chunk model cookbook #648
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks for the detailed explanation (my way of learning the world builder is to review everyone's pull requests :-)).
One question about the paraview state files, everything else is just minor typos.
For each feature, we need to choose the geometry and we can define the temperature model | ||
and the composition model to delineate layers in the plates and slab. | ||
|
||
* All the files for this cookbook maybe downloaded from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* All the files for this cookbook maybe downloaded from the | |
* All the files for this cookbook may be downloaded from the |
|
||
* All the files for this cookbook maybe downloaded from the | ||
[github cookbook page](https://github.com/GeodynamicWorldBuilder/WorldBuilder/tree/main/cookbooks/simple_subduction_2d_chunk) | ||
* It is may be helpful to read the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* It is may be helpful to read the | |
* It is maybe helpful to read the |
[github cookbook page](https://github.com/GeodynamicWorldBuilder/WorldBuilder/tree/main/cookbooks/simple_subduction_2d_chunk) | ||
* It is may be helpful to read the | ||
[Simple Subduction 2D Cartesian](part:user_manual:chap:cookbooks:sec:simple_subduction_2d_cartesian) | ||
Cookbook before continuing with this cook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cookbook before continuing with this cook. | |
Cookbook before continuing with this cookbook. |
in addition to the temperature. | ||
|
||
The figure below shows how the longitude angle is measured in the 3D World Builder space. | ||
the longitude parameter increases counter clockwise, from the x = 0. This is the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the longitude parameter increases counter clockwise, from the x = 0. This is the | |
the longitude parameter increases counter clockwise, from x = 0. This is the |
or
the longitude parameter increases counter clockwise, from the x = 0. This is the | |
the longitude parameter increases counter clockwise, from the y-axis. This is the |
|
||
The figure below shows how the longitude angle is measured in the 3D World Builder space. | ||
the longitude parameter increases counter clockwise, from the x = 0. This is the | ||
orientation that the output will appear if viewed in Paraview. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
orientation that the output will appear if viewed in Paraview. | |
orientation that the output will appear in if viewed in Paraview. |
the ridge) on a full 3D sphere, even though we are only interested in the effect within | ||
the limits of the grid we define. | ||
|
||
To specify that the half space model should meet the background adiabatic temperature, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To specify that the half space model should meet the background adiabatic temperature, | |
To specify that the half space cooling model should meet the background adiabatic temperature, |
Here we first add the compositional layer to continue the layer from the sinking plate. | ||
For the slab, we choose segments of different lengths, some with constant dip angle | ||
and others with variable dip. We also illustrate that the slab geometry can be overturned | ||
bu increasing the angle beyond 90 degree. We keep the `thickness` and `top truncation` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bu increasing the angle beyond 90 degree. We keep the `thickness` and `top truncation` | |
by increasing the angle beyond 90 degree. We keep the `thickness` and `top truncation` |
subducting plate velocity and length of the slab. The parameter `min distance slab top` | ||
has the same role as `top truncation` and the parameter `max distance slab top` has the | ||
same role as `thickness`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate on this a bit more? Why are there two parameters that are duplicated? Or do you mean: the one parameter plays the same role for the mass conserving temperature model as the other parameter for another model?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you really want to commit the paraview state files as well? without the data files they are not very useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, another paraview state file
8f01b53
to
a6b6502
Compare
|
@mibillen I think you forgot the check in |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #648 +/- ##
==========================================
+ Coverage 92.58% 98.23% +5.64%
==========================================
Files 92 106 +14
Lines 6368 7302 +934
==========================================
+ Hits 5896 7173 +1277
+ Misses 472 129 -343 see 29 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
I've added the missing file ... the needed file was there, but it had a different name. I committed and then "squashed" :-) |
Co-authored-by: Rene Gassmoeller <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, cookbook, thanks for writing this! It i very detailed and leads the user through your thought process in setting up this model. I also like that you put some try yourself exercises at the end :)
I found a few more of Rene's suggestions which for some reason didn't show up in the conversations page, but did in the files changed. They looked uncontroversial to me, so I just merged them.
This pull request address issue #535, case 2 although I decided to keep this cook book simpler, so it does not include a location specific model of points from slab 2.0. It does however, several small but tricky things about making 2D models in the spherical/chunk geometry.