Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple subduction 2d chunk model cookbook #648

Merged

Conversation

mibillen
Copy link
Contributor

This pull request address issue #535, case 2 although I decided to keep this cook book simpler, so it does not include a location specific model of points from slab 2.0. It does however, several small but tricky things about making 2D models in the spherical/chunk geometry.

Copy link
Contributor

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks for the detailed explanation (my way of learning the world builder is to review everyone's pull requests :-)).
One question about the paraview state files, everything else is just minor typos.

For each feature, we need to choose the geometry and we can define the temperature model
and the composition model to delineate layers in the plates and slab.

* All the files for this cookbook maybe downloaded from the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* All the files for this cookbook maybe downloaded from the
* All the files for this cookbook may be downloaded from the


* All the files for this cookbook maybe downloaded from the
[github cookbook page](https://github.com/GeodynamicWorldBuilder/WorldBuilder/tree/main/cookbooks/simple_subduction_2d_chunk)
* It is may be helpful to read the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* It is may be helpful to read the
* It is maybe helpful to read the

[github cookbook page](https://github.com/GeodynamicWorldBuilder/WorldBuilder/tree/main/cookbooks/simple_subduction_2d_chunk)
* It is may be helpful to read the
[Simple Subduction 2D Cartesian](part:user_manual:chap:cookbooks:sec:simple_subduction_2d_cartesian)
Cookbook before continuing with this cook.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Cookbook before continuing with this cook.
Cookbook before continuing with this cookbook.

in addition to the temperature.

The figure below shows how the longitude angle is measured in the 3D World Builder space.
the longitude parameter increases counter clockwise, from the x = 0. This is the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
the longitude parameter increases counter clockwise, from the x = 0. This is the
the longitude parameter increases counter clockwise, from x = 0. This is the

or

Suggested change
the longitude parameter increases counter clockwise, from the x = 0. This is the
the longitude parameter increases counter clockwise, from the y-axis. This is the


The figure below shows how the longitude angle is measured in the 3D World Builder space.
the longitude parameter increases counter clockwise, from the x = 0. This is the
orientation that the output will appear if viewed in Paraview.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
orientation that the output will appear if viewed in Paraview.
orientation that the output will appear in if viewed in Paraview.

the ridge) on a full 3D sphere, even though we are only interested in the effect within
the limits of the grid we define.

To specify that the half space model should meet the background adiabatic temperature,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To specify that the half space model should meet the background adiabatic temperature,
To specify that the half space cooling model should meet the background adiabatic temperature,

Here we first add the compositional layer to continue the layer from the sinking plate.
For the slab, we choose segments of different lengths, some with constant dip angle
and others with variable dip. We also illustrate that the slab geometry can be overturned
bu increasing the angle beyond 90 degree. We keep the `thickness` and `top truncation`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bu increasing the angle beyond 90 degree. We keep the `thickness` and `top truncation`
by increasing the angle beyond 90 degree. We keep the `thickness` and `top truncation`

Comment on lines 199 to 201
subducting plate velocity and length of the slab. The parameter `min distance slab top`
has the same role as `top truncation` and the parameter `max distance slab top` has the
same role as `thickness`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on this a bit more? Why are there two parameters that are duplicated? Or do you mean: the one parameter plays the same role for the mass conserving temperature model as the other parameter for another model?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you really want to commit the paraview state files as well? without the data files they are not very useful.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, another paraview state file

@mibillen mibillen force-pushed the simple_subduction_2d_chunk branch from 8f01b53 to a6b6502 Compare February 17, 2024 04:22
Copy link

github-actions bot commented Feb 17, 2024

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.011 ± 0.004 (s=438) 1.017 ± 0.003 (s=452) +0.6% .. +0.7%
Slab interpolation curved simple none 1.017 ± 0.006 (s=464) 1.017 ± 0.005 (s=423) -0.1% .. +0.2%
Spherical slab interpolation simple none 1.168 ± 0.008 (s=369) 1.166 ± 0.007 (s=405) -0.3% .. +0.0%
Slab interpolation simple curved CMS 1.063 ± 0.004 (s=435) 1.060 ± 0.004 (s=415) -0.3% .. -0.1%
Spherical slab interpolation simple CMS 1.550 ± 0.010 (s=305) 1.551 ± 0.010 (s=278) -0.1% .. +0.2%
Spherical fault interpolation simple none 1.173 ± 0.007 (s=374) 1.172 ± 0.006 (s=396) -0.2% .. +0.1%
Cartesian min max surface 2.289 ± 0.022 (s=202) 2.296 ± 0.027 (s=193) -0.1% .. +0.6%
Spherical min max surface 7.191 ± 0.025 (s=64) 7.194 ± 0.031 (s=64) -0.2% .. +0.3%

@MFraters
Copy link
Member

@mibillen I think you forgot the check in /cookbooks/simple_subduction_2d_chunk/simple_subduction_2d_chunk.grid. The tester need that to test the world builder file.

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.23%. Comparing base (5582bc9) to head (4dd5aa7).
Report is 158 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #648      +/-   ##
==========================================
+ Coverage   92.58%   98.23%   +5.64%     
==========================================
  Files          92      106      +14     
  Lines        6368     7302     +934     
==========================================
+ Hits         5896     7173    +1277     
+ Misses        472      129     -343     

see 29 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 760eadb...4dd5aa7. Read the comment docs.

@mibillen
Copy link
Contributor Author

I've added the missing file ... the needed file was there, but it had a different name. I committed and then "squashed" :-)

Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, cookbook, thanks for writing this! It i very detailed and leads the user through your thought process in setting up this model. I also like that you put some try yourself exercises at the end :)

I found a few more of Rene's suggestions which for some reason didn't show up in the conversations page, but did in the files changed. They looked uncontroversial to me, so I just merged them.

@MFraters MFraters added the ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews. label Feb 25, 2024
@MFraters MFraters merged commit ac9e4a7 into GeodynamicWorldBuilder:main Feb 25, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull request is ready to merge. May be waiting for tests to complete or other reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants