Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add description of the plume feature #642

Merged
merged 5 commits into from
Feb 18, 2024

Conversation

jdannberg
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4539ca8) 92.80% compared to head (031fd86) 92.78%.
Report is 67 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #642      +/-   ##
==========================================
- Coverage   92.80%   92.78%   -0.02%     
==========================================
  Files          92      105      +13     
  Lines        6474     7177     +703     
==========================================
+ Hits         6008     6659     +651     
- Misses        466      518      +52     

see 24 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4539ca8...031fd86. Read the comment docs.

Copy link

github-actions bot commented Feb 16, 2024

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.015 ± 0.005 (s=468) 1.013 ± 0.006 (s=422) -0.3% .. -0.0%
Slab interpolation curved simple none 1.017 ± 0.006 (s=464) 1.015 ± 0.006 (s=424) -0.3% .. -0.1%
Spherical slab interpolation simple none 1.168 ± 0.006 (s=397) 1.165 ± 0.006 (s=377) -0.4% .. -0.1%
Slab interpolation simple curved CMS 1.054 ± 0.004 (s=425) 1.060 ± 0.005 (s=429) +0.5% .. +0.7%
Spherical slab interpolation simple CMS 1.549 ± 0.010 (s=289) 1.548 ± 0.010 (s=295) -0.2% .. +0.1%
Spherical fault interpolation simple none 1.171 ± 0.008 (s=386) 1.171 ± 0.007 (s=385) -0.1% .. +0.2%
Cartesian min max surface 2.293 ± 0.017 (s=201) 2.295 ± 0.017 (s=194) -0.2% .. +0.3%
Spherical min max surface 7.212 ± 0.031 (s=53) 7.217 ± 0.032 (s=74) -0.2% .. +0.3%

Copy link
Contributor

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All text and pictures look good to me. @MFraters can you check if the structure that is suggested looks ok to you?

Plume
======================

The plume feature allows it to add a mantle plume to a GWB world. Specifically, the plume is described in terms of its centerline and a number of cross sections.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not wrong, but I would prefer:

Suggested change
The plume feature allows it to add a mantle plume to a GWB world. Specifically, the plume is described in terms of its centerline and a number of cross sections.
The plume feature allows to add a mantle plume to a GWB world. Specifically, the plume is described in terms of its centerline and a number of cross sections.

The plume feature allows it to add a mantle plume to a GWB world. Specifically, the plume is described in terms of its centerline and a number of cross sections.
The location of the centerline of the plume is prescribed through the `coordinates` and the `cross section depths` parameter. The coordinates express the location of the plume center projected onto the surface of the model. In other words, the coordinates are 2D points, defining the x and y location of the plume center (in a Cartesian geometry) or the latitude and longitude of the plume center (in a spherical geometry). The cross section depths describe the depth of each of these 2D points, and they have to be listed from top to bottom (in order of ascending depth). The plume centerline is then computed through a linear interpolation between these points.

At each point on the plume centerline defined in this way, the shape of the cross section of the plume needs to be described. We assume that the cross section has an elliptical shape, so it can be defined in terms of the length of the semi-major axis, the direction of the semi-major axis, and the eccentricity of the ellipse. This combination of parameter allows it to prescribe a pipe-like structure with changing cross-sections.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easier to read:

Suggested change
At each point on the plume centerline defined in this way, the shape of the cross section of the plume needs to be described. We assume that the cross section has an elliptical shape, so it can be defined in terms of the length of the semi-major axis, the direction of the semi-major axis, and the eccentricity of the ellipse. This combination of parameter allows it to prescribe a pipe-like structure with changing cross-sections.
At each central point defined in this way, the shape of the cross section of the plume needs to be described. We assume that the cross section has an elliptical shape, so it can be defined in terms of the length of the semi-major axis, the direction of the semi-major axis, and the eccentricity of the ellipse. This combination of parameters allows it to prescribe a pipe-like structure with changing cross-sections.

@jdannberg
Copy link
Contributor Author

I addressed your comments.

Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this up and creating this new part for the manual!

@MFraters MFraters merged commit d9c2f64 into GeodynamicWorldBuilder:main Feb 18, 2024
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants