Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: feature list #635

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

tjhei
Copy link
Contributor

@tjhei tjhei commented Feb 16, 2024

  • put area/line/point features on a single page (pages were very short)
  • include a list of all current features

- put area/line/point features on a single page (pages were very short)
- include a list of all current features
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (274a7ee) 92.58% compared to head (e5181d1) 92.58%.
Report is 14 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #635   +/-   ##
=======================================
  Coverage   92.58%   92.58%           
=======================================
  Files          92       92           
  Lines        6368     6368           
=======================================
  Hits         5896     5896           
  Misses        472      472           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 274a7ee...e5181d1. Read the comment docs.

Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the one page is indeed better for this, but I think you used the text from before the edits Lorraine made. Can you update them?

Copy link

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.017 ± 0.003 (s=401) 1.014 ± 0.003 (s=488) -0.4% .. -0.3%
Slab interpolation curved simple none 1.018 ± 0.006 (s=442) 1.015 ± 0.005 (s=446) -0.5% .. -0.2%
Spherical slab interpolation simple none 1.162 ± 0.006 (s=404) 1.165 ± 0.005 (s=372) +0.1% .. +0.3%
Slab interpolation simple curved CMS 1.060 ± 0.008 (s=443) 1.055 ± 0.004 (s=410) -0.6% .. -0.4%
Spherical slab interpolation simple CMS 1.544 ± 0.009 (s=285) 1.545 ± 0.009 (s=300) -0.1% .. +0.2%
Spherical fault interpolation simple none 1.168 ± 0.006 (s=389) 1.171 ± 0.007 (s=383) +0.1% .. +0.4%
Cartesian min max surface 2.304 ± 0.019 (s=192) 2.303 ± 0.015 (s=201) -0.3% .. +0.2%
Spherical min max surface 7.209 ± 0.029 (s=60) 7.217 ± 0.051 (s=67) -0.2% .. +0.5%

@MFraters MFraters merged commit 5a44151 into GeodynamicWorldBuilder:main Feb 16, 2024
33 of 34 checks passed
@tjhei tjhei deleted the doc-features branch February 16, 2024 21:34
@ljhwang
Copy link
Contributor

ljhwang commented Feb 19, 2024

I think I am late to the party. Is there something I need to do still?

I would also consider changing the headings from # to ##

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants