Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update area_features.md #626

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

ljhwang
Copy link
Contributor

@ljhwang ljhwang commented Feb 16, 2024

Some extensive rewriting. I think this is what you actually mean. Please review.

Please feel free to edit.

Some extensive rewriting. I think this is what you actually mean.  Please review.

Please feel free to edit.
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dfbb30b) 93.11% compared to head (b566aa9) 93.13%.
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #626      +/-   ##
==========================================
+ Coverage   93.11%   93.13%   +0.01%     
==========================================
  Files          92       92              
  Lines        6334     6334              
==========================================
+ Hits         5898     5899       +1     
+ Misses        436      435       -1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfbb30b...b566aa9. Read the comment docs.

Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for translating my writing to something readable ;)

@MFraters MFraters merged commit 8014b73 into GeodynamicWorldBuilder:main Feb 16, 2024
33 of 34 checks passed
Copy link

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.012 ± 0.005 (s=425) 1.015 ± 0.004 (s=465) +0.2% .. +0.4%
Slab interpolation curved simple none 1.010 ± 0.003 (s=454) 1.013 ± 0.004 (s=438) +0.2% .. +0.3%
Spherical slab interpolation simple none 1.166 ± 0.007 (s=403) 1.168 ± 0.007 (s=371) -0.0% .. +0.3%
Slab interpolation simple curved CMS 1.057 ± 0.005 (s=406) 1.055 ± 0.004 (s=449) -0.3% .. -0.1%
Spherical slab interpolation simple CMS 1.547 ± 0.010 (s=290) 1.546 ± 0.009 (s=294) -0.3% .. +0.1%
Spherical fault interpolation simple none 1.171 ± 0.009 (s=386) 1.172 ± 0.006 (s=385) -0.1% .. +0.2%
Cartesian min max surface 2.312 ± 0.024 (s=208) 2.325 ± 0.019 (s=183) +0.2% .. +0.9%
Spherical min max surface 7.205 ± 0.027 (s=61) 7.229 ± 0.033 (s=66) +0.1% .. +0.6%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants